Add worker indexing message types to protobuf #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added messages to handle worker indexing pipeline WorkerFunctionMetadata includes all information necessary to populate FunctionMetadata and convey the indexing status for each function (ie. success, failure, etc.). Each of these messages corresponds to a single function. WorkerFunctionMetadataRequest sends the function app directory to the worker. WorkerFunctionMetadataResponse includes a list of WorkerFunctionMetadata messages and an overall StatusResult attribute.
pragnagopa
reviewed
Jul 20, 2021
Removed WorkerFunctionMetadata message type and added some necessary fields to RpcFunctionMetadata Renamed request and response messages to be more bi-directional friendly
pragnagopa
reviewed
Jul 30, 2021
pragnagopa
requested changes
Jul 30, 2021
Rename directory variable for consistency and clarity
|
Have you considered how host can handle reloading of functions by the worker ? i.e. python worker can reload functions without restarting the process on file changes --> then when worker is re-indexes the functions --> it should send FunctionsLoadResponses again --> this means I would like understand a bit more on the requirement for Host to send first message asking to load functions --- this might not be needed? |
|
@pragnagopa I think this requires more discussion, I'll set up a time to meet. |
pragnagopa
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FunctionsMetadataRequestFunctionMetadataResponses