Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update table client creation during Assistant Post and Assistant Query #114

Merged
merged 11 commits into from
Oct 2, 2024
Merged

Update table client creation during Assistant Post and Assistant Query #114

merged 11 commits into from
Oct 2, 2024

Conversation

manvkaur
Copy link
Collaborator

@manvkaur manvkaur commented Sep 23, 2024 •
edited
Loading

Fix for #112

  1. Create Table Client if null during AssistantPost and AssistantQuery
  2. Java library updated to include above
  3. Samples updated with passing default values for AssistantCreate, AssistantPost and AssistantQuery
  4. null checks added (reported in code quality rules violations)
  5. Nuget dependencies updated for WebJobs OpenAI and Worker OpenAI

To Do (next PR):

@manvkaur manvkaur linked an issue Sep 23, 2024 that may be closed by this pull request
[Bug] Using managed identity for chat table storage results in "Exception while executing function: Functions.GetChatState The assistant must be initialized first using CreateAssistantAsync (Parameter 'tableClient')" when calling a Post or Get after the chat is initialized successfully #112
Closed
@manvkaur manvkaur mentioned this pull request Sep 23, 2024
Merged
cgillum
cgillum reviewed Sep 24, 2024
View reviewed changes
Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor suggestions.

cgillum
cgillum reviewed Sep 27, 2024
View reviewed changes
Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor corrections for the previous table client refactoring.

@manvkaur manvkaur merged commit b21d151 into main Oct 2, 2024
8 checks passed
@manvkaur manvkaur deleted the manvkaur/tableclientupdate branch October 2, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aishwaryabh aishwaryabh aishwaryabh left review comments

@cgillum cgillum cgillum approved these changes

@vrdmr vrdmr Awaiting requested review from vrdmr vrdmr is a code owner

@gavin-aguiar gavin-aguiar Awaiting requested review from gavin-aguiar gavin-aguiar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@manvkaur @cgillum @aishwaryabh