Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved SqlRow from _abc #150

Merged
merged 9 commits into from
Jan 24, 2023
Merged

Moved SqlRow from _abc #150

merged 9 commits into from
Jan 24, 2023

Conversation

gavin-aguiar
Copy link
Contributor

@gavin-aguiar gavin-aguiar commented Nov 12, 2022

Moved sqlrow from _abc to sql.py

@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Merging #150 (ca129ba) into dev (0f155a9) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #150      +/-   ##
==========================================
+ Coverage   90.10%   90.25%   +0.15%     
==========================================
  Files          51       51              
  Lines        3000     2995       -5     
  Branches      796      796              
==========================================
  Hits         2703     2703              
+ Misses        220      215       -5     
  Partials       77       77              
Flag Coverage Δ
unittests 90.21% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure/functions/_abc.py 75.82% <ø> (+0.05%) ⬆️
azure/functions/_sql.py 100.00% <100.00%> (ø)
azure/functions/sql.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs tests. Please add them. Otherwise LGTM

@gavin-aguiar gavin-aguiar merged commit 1c7fc6c into dev Jan 24, 2023
@gavin-aguiar gavin-aguiar deleted the gaaguiar/sql_fix branch January 24, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants