Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decorator typehints #162

Merged
merged 3 commits into from
Jan 25, 2023
Merged

Conversation

baluyotraf
Copy link
Contributor

@baluyotraf baluyotraf commented Jan 23, 2023

This fixes other type hints not covered by #160. #160 fixed all the callable related type hints, but some decorators do not have their parameter type hints fully defined.

The main issue is Azure/azure-functions-python-worker#1161

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #162 (3d8b8cc) into dev (1c7fc6c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #162   +/-   ##
=======================================
  Coverage   90.25%   90.25%           
=======================================
  Files          51       51           
  Lines        2995     2995           
  Branches      796      796           
=======================================
  Hits         2703     2703           
  Misses        215      215           
  Partials       77       77           
Flag Coverage Δ
unittests 90.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure/functions/decorators/function_app.py 99.44% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@YunchuWang YunchuWang merged commit 29af5ef into Azure:dev Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants