Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some unclear definition docs in AppExtensionBase #174

Merged
merged 3 commits into from
Apr 28, 2023

Conversation

hvt
Copy link
Contributor

@hvt hvt commented Mar 10, 2023

Besides, fixed some obvious spelling mistakes in the same module.

@hvt
Copy link
Contributor Author

hvt commented Mar 10, 2023

@microsoft-github-policy-service agree company="IXON B.V."

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #174 (669de1e) into dev (27bead7) will decrease coverage by 0.24%.
The diff coverage is n/a.

❗ Current head 669de1e differs from pull request most recent head b254938. Consider uploading reports for the commit b254938 to get more accurate results

@@            Coverage Diff             @@
##              dev     #174      +/-   ##
==========================================
- Coverage   90.51%   90.28%   -0.24%     
==========================================
  Files          53       53              
  Lines        3122     3046      -76     
  Branches      815      809       -6     
==========================================
- Hits         2826     2750      -76     
  Misses        219      219              
  Partials       77       77              
Flag Coverage Δ
unittests 90.24% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure/functions/extension/app_extension_base.py 81.81% <ø> (ø)
azure/functions/extension/extension_meta.py 96.10% <ø> (ø)
...unctions/extension/function_extension_exception.py 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks a lot for making the changes. Apologies for the delay in getting this in.

@gavin-aguiar gavin-aguiar merged commit 172c778 into Azure:dev Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants