Added support for CosmosDB v4 extension #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #175 +/- ##
==========================================
+ Coverage 90.28% 90.51% +0.23%
==========================================
Files 53 53
Lines 3046 3122 +76
Branches 809 815 +6
==========================================
+ Hits 2750 2826 +76
Misses 219 219
Partials 77 77
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gavin-aguiar
requested review from
vrdmr,
YunchuWang and
pdthummar
as code owners
YunchuWang
approved these changes
Apr 26, 2023
vrdmr
approved these changes
Apr 27, 2023
| @@ -106,3 +107,103 @@ def __init__(self, | |||
| self.database_name = database_name | |||
| self.collection_name = collection_name | |||
| super().__init__(name=name, data_type=data_type) | |||
|
|
|||
|
|
|||
| class CosmosDBInput(InputBinding): | |||
There was a problem hiding this comment.
In the comments, could you please add a description of what is the difference between CosmosDBTriggerV3 vs CosmosDBTrigger so that that info is in the code.
| CosmosDB data is changed. | ||
| indexing model. This decorator will work only with extension bundle 2.x | ||
| or 3.x. For additional details, please refer | ||
| https://github.com/Azure/azure-functions-python-worker/issues/1222. |
There was a problem hiding this comment.
Why not put an aka.ms link or mslearn link? aka.ms can be tracked.
| All optional fields will be given default value by function host when | ||
| they are parsed by function host. | ||
|
|
||
| Ref: https://aka.ms/azure-function-binding-cosmosdb-v2 |
There was a problem hiding this comment.
You might need another aka.ms link which pivots to
There was a problem hiding this comment.
Similar comments to the other decorators as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for cosmos db v4 extension for the new programming model.
New decorators for cosmosdb:
Extension 2.x and 3.x
Extension 4.x and above
The new v4 cosmos db extension installation can be found here
The latest support configurations for the new programming model can be found here