Retry policy support for v2 #182
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #182 +/- ##
==========================================
+ Coverage 90.50% 90.70% +0.20%
==========================================
Files 106 55 -51
Lines 6256 3185 -3071
Branches 1097 822 -275
==========================================
- Hits 5662 2889 -2773
+ Misses 439 219 -220
+ Partials 155 77 -78
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gavin-aguiar
force-pushed
the
gaaguiar/retry_policy
branch
from
d087564 to
9880a04
Compare
gavin-aguiar
requested review from
vrdmr,
YunchuWang and
pdthummar
as code owners
| return setting | ||
| return None | ||
|
|
||
| def get_settings_json(self, setting_name) -> Optional[Dict]: |
There was a problem hiding this comment.
Change this to get_setting_dict rather than json as this isn't serializing the json.
| @@ -145,12 +176,12 @@ def get_user_function(self) -> Callable[..., Any]: | |||
| """ | |||
| return self._func | |||
|
|
|||
| def get_function_name(self) -> str: | |||
| """Get the function name. | |||
| # def get_function_name(self) -> str: | |||
| def function_name(self, name: str, | ||
| setting_extra_fields: Dict[str, Any] = {}, | ||
| ) -> Callable[..., Any]: | ||
| """Set name of the :class:`Function` object. |
There was a problem hiding this comment.
Add that this is optional and if not set, we will pickup the method name
| **setting_extra_fields)) | ||
| return fb | ||
|
|
||
| return decorator() |
There was a problem hiding this comment.
Are we planning to add validation to ensure basic combinations are not missed? Better to raise it here
There was a problem hiding this comment.
No. Validations will be in the host. If we add a validation here it will hide the host error and only show no functions found in the logs
There was a problem hiding this comment.
We should at least send a warning - better wording of the validation
There was a problem hiding this comment.
Discussed this offline can validations across the library coming later.
| @@ -1987,7 +2086,7 @@ def register_functions(self, function_container: DecoratorApi) -> None: | |||
| register_blueprint = register_functions | |||
|
|
|||
|
|
|||
| class FunctionApp(FunctionRegister, TriggerApi, BindingApi): | |||
| class FunctionApp(FunctionRegister, TriggerApi, BindingApi, SettingsApi): | |||
There was a problem hiding this comment.
This is becoming more complicated day by day
docs/ProgModelSpec.pyi
Outdated
There was a problem hiding this comment.
Curious if we need to maintain this file - or a way to autogenerate this - using sphinx thing that I was trying.
| @@ -116,6 +117,36 @@ def get_bindings(self) -> List[Binding]: | |||
| """ | |||
| return self._bindings | |||
|
|
|||
| def get_setting(self, setting_name: str) -> Optional[Setting]: | |||
There was a problem hiding this comment.
Where do we get the list of all the settings registered to the Function? where you can get the setting_name itself from? I don't see it within a Function
There was a problem hiding this comment.
class Functions has a List[Settings] which should have all the settings for a function
| All optional fields will be given default value by function host when | ||
| they are parsed by function host. | ||
|
|
||
| Ref: https://aka.ms/azure-function-retry <FIX LINK> |
| **setting_extra_fields)) | ||
| return fb | ||
|
|
||
| return decorator() |
There was a problem hiding this comment.
We should at least send a warning - better wording of the validation
tests/decorators/test_core.py
Outdated
| class TestSettings(unittest.TestCase): | ||
|
|
||
| def test_setting_creation(self): | ||
| test_setting = DummySetting(setting_type="TestSetting") |
There was a problem hiding this comment.
This seems a little counter intuitive -
DummySetting(setting_type="TestSetting") - it is implicitly picking up the name of setting ("setting_type")
Can you show how the function_name setting will be defined?
There was a problem hiding this comment.
Updated and added comments
| **setting_extra_fields)) | ||
| return fb | ||
|
|
||
| return decorator() |
There was a problem hiding this comment.
Discussed this offline can validations across the library coming later.
Added support for retry policy for V2 programming model.
PR includes adding a new SettingApi which is similar to TriggerApi and BindingsApi.
Function Name and Retry decorators will be part of the SettingsApi