-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add support for PEP 585 type hinting for 3.9+ #199
Open
YunchuWang
wants to merge
14
commits into
dev
Choose a base branch
from
wangbill/native-type-hint
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+47
−6
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
53ccfab
support standard collection types in type hint for 3.9+
YunchuWang 414cb0a
fix
YunchuWang 87e06b8
fix
YunchuWang 6583719
fix
YunchuWang 1b8c295
fix
YunchuWang e1ba535
fix
YunchuWang 0648666
change tests
YunchuWang 5c02cba
fix
YunchuWang 862f0ca
fix
YunchuWang 45e853d
fix eh tests
YunchuWang 94739ae
fix
YunchuWang e0b550c
Merge branch 'dev' into wangbill/native-type-hint
hallvictoria 7cbabd6
Merge branch 'dev' into wangbill/native-type-hint
hallvictoria 3095502
docs
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is
typing_inspect.is_generic_type(annotation)
not included in >3.9?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is_generic_type
will fail for thelist
type -- this is a method we defined.get_origin
expands on our definition ofis_generic_type
but includes the built-in collection types.get_origin
supports the generic types and returns a non-None value whereis_generic_type
would return true