-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: asgi/wsgifunctionapps to extend bindingapi/settingapi #209
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #209 +/- ##
=======================================
Coverage 93.10% 93.10%
=======================================
Files 56 56
Lines 3247 3247
Branches 666 666
=======================================
Hits 3023 3023
Misses 137 137
Partials 87 87
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #209 +/- ##
=======================================
Coverage 93.10% 93.10%
=======================================
Files 56 56
Lines 3247 3247
Branches 666 666
=======================================
Hits 3023 3023
Misses 137 137
Partials 87 87
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@vrdmr @gavin-aguiar @pdthummar @hallvictoria Could we get a comment / review of this please? This is breaking a significant part of the integration with fastapi, which the official documentation suggests to use. |
fix Azure/azure-functions-python-worker#1422
AsgiFunctionApp should support bindingapi and settingapi functionalities as shown below. Tested e2e locally working.
