Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: asgi/wsgifunctionapps to extend bindingapi/settingapi #209

Merged
merged 5 commits into from
Jul 17, 2024

Conversation

YunchuWang
Copy link
Member

@YunchuWang YunchuWang commented Mar 8, 2024

fix Azure/azure-functions-python-worker#1422

AsgiFunctionApp should support bindingapi and settingapi functionalities as shown below. Tested e2e locally working.
image

image

image

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.10%. Comparing base (31f3d42) to head (d679d3a).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #209   +/-   ##
=======================================
  Coverage   93.10%   93.10%           
=======================================
  Files          56       56           
  Lines        3247     3247           
  Branches      666      666           
=======================================
  Hits         3023     3023           
  Misses        137      137           
  Partials       87       87           
Flag Coverage Δ
unittests 93.07% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.10%. Comparing base (b85eb7a) to head (d679d3a).
Report is 3 commits behind head on dev.

❗ Current head d679d3a differs from pull request most recent head a346132. Consider uploading reports for the commit a346132 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #209   +/-   ##
=======================================
  Coverage   93.10%   93.10%           
=======================================
  Files          56       56           
  Lines        3247     3247           
  Branches      666      666           
=======================================
  Hits         3023     3023           
  Misses        137      137           
  Partials       87       87           
Flag Coverage Δ
unittests 93.07% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gavin-aguiar and others added 2 commits April 25, 2024 16:02
@ltalirz
Copy link

ltalirz commented Jul 17, 2024

@vrdmr @gavin-aguiar @pdthummar @hallvictoria Could we get a comment / review of this please?

This is breaking a significant part of the integration with fastapi, which the official documentation suggests to use.

@hallvictoria hallvictoria changed the title fix asgi/wsgifunctionapps to extend bindingapi/settingapi fix: asgi/wsgifunctionapps to extend bindingapi/settingapi Jul 17, 2024
@hallvictoria hallvictoria merged commit ff2e803 into dev Jul 17, 2024
10 of 11 checks passed
@hallvictoria hallvictoria deleted the wangbill/asgi-wsgi-fix branch July 17, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] AsgiFunctionApp is missing BindingApi and SettingsApi mixins
5 participants