Retry policy support for v2 programming model #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 4, 2023 14:31
gavin-aguiar
force-pushed
the
gaaguiar/retry_context
branch
from
f58aca0 to
92efc8c
Compare
Codecov Report
@@ Coverage Diff @@
## dev #1268 +/- ##
===========================================
- Coverage 84.40% 32.31% -52.09%
===========================================
Files 34 34
Lines 1904 1925 +21
Branches 366 281 -85
===========================================
- Hits 1607 622 -985
- Misses 228 1302 +1074
+ Partials 69 1 -68
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gavin-aguiar
requested review from
vrdmr,
YunchuWang and
pdthummar
as code owners
vrdmr
reviewed
Jul 6, 2023
|
|
||
| return retry_protos | ||
|
|
||
|
|
||
| def process_indexed_function(functions_registry: functions.Registry, |
There was a problem hiding this comment.
Do we have a test which validates the json being generated?
added 2 commits
July 6, 2023 11:02
vrdmr
approved these changes
Jul 6, 2023
| self.assertEqual(protos.max_retry_count, 1) | ||
| self.assertEqual(protos.retry_strategy, 1) | ||
| self.assertEqual(protos.delay_interval.seconds, 1) | ||
|
|
added 2 commits
July 6, 2023 15:03
vrdmr
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for retry policy for v2 programming model.
Retrieving the values for retry policy from the decorator, converting it to a protobuf message and sending it to the host.
Fixes #
PR information
Quality of Code and Contribution Guidelines