Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Bus batch support #2224

Closed
wants to merge 20 commits into from
Closed

Service Bus batch support #2224

wants to merge 20 commits into from

Conversation

alrod
Copy link
Member

@alrod alrod commented Jun 11, 2019

Resolves #1024

It turned out that it's hard to implement batch processing using current architecture. Currently ServiceBus extension uses old non-generic approach with custom converters, collectors, etc.
So I tried to refactor ServiceBus extension using new approach (EventHub for example). I did not find ways to implement few things using new approach:

  1. Poco converter uses only Json deserialization:
    https://github.com/Azure/azure-webjobs-sdk/blob/dev/src/Microsoft.Azure.WebJobs.Host/Triggers/TriggerArgumentBinding/PocoTriggerArgumentBinding.cs#L42
    SB message can be deserialized as XML using Message.GetBody<T>()
  2. ParameterizedServiceBusPath for output bindings: https://github.com/Azure/azure-webjobs-sdk/blob/dev/src/Microsoft.Azure.WebJobs.Extensions.ServiceBus/Bindings/ParameterizedServiceBusPath.cs.
  3. Adding function invocationId to UserProperties
    https://github.com/Azure/azure-webjobs-sdk/blob/dev/src/Microsoft.Azure.WebJobs.Extensions.ServiceBus/Listeners/ServiceBusCausalityHelper.cs#L15

@alrod alrod force-pushed the alrod-sb-batch2 branch from 0347c9c to d92f008 Compare June 18, 2019 01:38
@batizar
Copy link

batizar commented Jul 8, 2019

@alrod any ideas about the estimated release of this feature? thanks.

@kwasak
Copy link

kwasak commented Oct 6, 2019

Any update on when this might be released?

@fabiocav
Copy link
Member

@alrod closing stale PR. Please address conflicts and ping for review once ready. Thanks!

@fabiocav fabiocav closed this Jul 22, 2020
@fabiocav fabiocav deleted the alrod-sb-batch2 branch September 12, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants