Add connect method to set destination server. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siadatism
requested changes
Dec 18, 2023
| catch { | ||
| Write-Error "Nvm is not installed, install it manually to continue." | ||
| } | ||
| # try { |
There was a problem hiding this comment.
در Pull Request کد کامنت شده نداشته باشیم
There was a problem hiding this comment.
Why remove nvm installation?
siadatism
approved these changes
Dec 30, 2023
siadatism
changed the title
soroshsabz
requested changes
Dec 30, 2023
| Description = "Target Server Address" } | ||
| } | ||
| } | ||
| Url = "http://resaa.net/", |
There was a problem hiding this comment.
Passive aggressive comment :D
soroshsabz
reviewed
Dec 30, 2023
soroshsabz
reviewed
Dec 30, 2023
| string requestUriString = request.RequestUri.ToString(); | ||
| Uri newUri = new Uri(requestUriString); | ||
| string host = newUri.Host; | ||
| string finalUrl = requestUriString.Replace(host,serverAddress); |
soroshsabz
reviewed
Dec 30, 2023
soroshsabz
reviewed
Dec 30, 2023
soroshsabz
reviewed
Dec 30, 2023
soroshsabz
reviewed
Dec 30, 2023
added 2 commits
January 2, 2024 01:54
….com/BSVN/IpTables.Api into feature/add-connect-method-with-file
soroshsabz
requested changes
Jan 3, 2024
| Description = "Target Server Address" } | ||
| } | ||
| } | ||
| Url = "http://resaa.net/", |
…when-serveraddress-is-empty-in-module.cs
…when-serveraddress-is-empty-in-module.cs
siadatism
approved these changes
Jan 26, 2024
soroshsabz
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
submit final version of connection method in cmdlet 2023-12-16
fixes #34