This repository was archived by the owner on Oct 14, 2024. It is now read-only.
[Feat] Witness navigation #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieleformichelli
approved these changes
Jun 4, 2021
LorDisturbia
approved these changes
Jun 4, 2021
FEC-bendingspoons
approved these changes
Jun 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This PR allows the enriching of the
Navigationobject with aRoutableProviderto allow Tempura to handle its navigation without being the only manager of the app's navigation.This is needed when Tempura is added on top of another architecture that already has control of the navigation.
Changes
Enrich init of
Navigationobject with aRoutableProviderinited with a default value that is the live implementation.Tasks