-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
es6 it! #11
Comments
Seems legit. Maybe having an own branch for es6 is a good thing? So tagging different branches is made easier an makes the codebase compatible for older interpreter and users can choose a compatible version as they need. |
If we were to do it, I'd first create a new branch, then I'd like to ensure we use something like babel to compile it for compatibility. I'd also like to make part of the build process create a browser specific file, so that rather than doing it manually, it is built in. All of which wouldn't be too complicated. |
Once all that clears, then we could merge it into master, and continue on our merry way. |
It is here, huzzah! |
There's a tool caled |
very cool! |
What would be our strategy for es5/legacy compatibility? |
Why not transpile it to es5 with babel as a prepublish step? That seems to be the normal route for modules written in es6+. |
I like it! |
@IonicaBizau I mostly manually translated it already. |
Ready and waiting here: #28 |
As soon as this is merged, auto builds are next, then a pr for the recurrent neural network stuff. Just fyi. |
Merged! |
For publishing I use |
Would you be up for taking a look at master, and seeing if you can apply your knowledge there? |
@robertleeplummerjr Well, pretty much |
rnn, lstm, and gru working 100%, with some simple unit tests and travic-ci build: #29 |
I'd like to update the syntax to that of es6, thoughts?
The text was updated successfully, but these errors were encountered: