Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es6 it! #11

Closed
robertleeplummerjr opened this issue May 22, 2016 · 17 comments
Closed

es6 it! #11

robertleeplummerjr opened this issue May 22, 2016 · 17 comments
Assignees

Comments

@robertleeplummerjr
Copy link
Contributor

I'd like to update the syntax to that of es6, thoughts?

@MrIsaacs
Copy link

MrIsaacs commented May 28, 2016

Seems legit. Maybe having an own branch for es6 is a good thing? So tagging different branches is made easier an makes the codebase compatible for older interpreter and users can choose a compatible version as they need.

@robertleeplummerjr
Copy link
Contributor Author

If we were to do it, I'd first create a new branch, then I'd like to ensure we use something like babel to compile it for compatibility. I'd also like to make part of the build process create a browser specific file, so that rather than doing it manually, it is built in. All of which wouldn't be too complicated.

@robertleeplummerjr
Copy link
Contributor Author

Once all that clears, then we could merge it into master, and continue on our merry way.

@robertleeplummerjr
Copy link
Contributor Author

It is here, huzzah!

@IonicaBizau
Copy link
Member

There's a tool caled lebab by @mohebifar which would be probably useful to convert it automagically and then edit the things that still have to be edited manually (if any). 😁

@robertleeplummerjr
Copy link
Contributor Author

very cool!

@robertleeplummerjr
Copy link
Contributor Author

What would be our strategy for es5/legacy compatibility?

@Macil
Copy link

Macil commented Aug 26, 2016

Why not transpile it to es5 with babel as a prepublish step? That seems to be the normal route for modules written in es6+.

@robertleeplummerjr
Copy link
Contributor Author

I like it!

@robertleeplummerjr
Copy link
Contributor Author

@IonicaBizau I mostly manually translated it already.

@robertleeplummerjr
Copy link
Contributor Author

Ready and waiting here: #28

@robertleeplummerjr
Copy link
Contributor Author

As soon as this is merged, auto builds are next, then a pr for the recurrent neural network stuff. Just fyi.

@robertleeplummerjr robertleeplummerjr self-assigned this Sep 6, 2016
@robertleeplummerjr
Copy link
Contributor Author

Merged!

@IonicaBizau
Copy link
Member

For publishing I use babel-it which babelifies the files in place when npm publishing.

@robertleeplummerjr
Copy link
Contributor Author

Would you be up for taking a look at master, and seeing if you can apply your knowledge there?

@IonicaBizau
Copy link
Member

@robertleeplummerjr Well, pretty much npm i -g babel-it and instead of doing npm publish you do babel-it. 😁

@robertleeplummerjr
Copy link
Contributor Author

rnn, lstm, and gru working 100%, with some simple unit tests and travic-ci build: #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants