Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ti::real C++ class wrapping TI's real number format and OS funcs #258

Merged
merged 2 commits into from
Nov 2, 2020
Merged

Add ti::real C++ class wrapping TI's real number format and OS funcs #258

merged 2 commits into from
Nov 2, 2020

Conversation

adriweb
Copy link
Member

@adriweb adriweb commented May 3, 2020 •
edited
Loading

TODO:

  • Better math-oriented example?
  • Autotest on that example
  • wrap the remaining functions

@adriweb adriweb requested review from debrouxl, jacobly0 and runer112 May 3, 2020 04:50
@adriweb adriweb requested a review from mateoconlechuga May 3, 2020 04:50
@adriweb
Copy link
Member Author

adriweb commented May 3, 2020

We could (should) probably come up with a fancy math example though.

@erentar
Copy link

erentar commented May 3, 2020

Please put the monte carlo pi as math example

@adriweb
Copy link
Member Author

adriweb commented May 5, 2020

Sure, that's easy enough

@jacobly0 jacobly0 force-pushed the llvm branch 4 times, most recently from c5e4557 to 5dc1886 Compare August 9, 2020 03:38
@jacobly0 jacobly0 force-pushed the llvm branch 2 times, most recently from 8865f33 to ca4a1a7 Compare August 9, 2020 03:54
@jacobly0 jacobly0 force-pushed the llvm branch 8 times, most recently from 0db84bf to 300c97f Compare August 10, 2020 00:27
@mateoconlechuga mateoconlechuga force-pushed the llvm branch 2 times, most recently from 4a8561d to 72bbe53 Compare September 20, 2020 06:50
@mateoconlechuga mateoconlechuga force-pushed the llvm branch 9 times, most recently from ba1159d to 2ce370f Compare September 21, 2020 11:31
@adriweb adriweb force-pushed the feature/tireal branch 4 times, most recently from bbc51d4 to 8600015 Compare September 23, 2020 22:20
jacobly0 added a commit that referenced this pull request Oct 4, 2020
@jacobly0
Test PR #258.
fed81c0
@adriweb
Copy link
Member Author

adriweb commented Oct 4, 2020

OK, review plz, I added more functions and tests.

mateoconlechuga
mateoconlechuga reviewed Nov 1, 2020
View reviewed changes
adriweb and others added 2 commits November 1, 2020 19:25
@adriweb @runer112 @jacobly0
Add ti::real C++ class wrapping TI's real number format and OS functi…
c41eb16 
…ons.

It provides a bunch of compile-time helpers/utilities, too.

Original idea and initial simple code by Adriweb.
Much improved and fancier code (constexpr stuff, most notably) by Jacobly and Runer112.

Co-authored-by: Zachary Wassall <[email protected]>
Co-authored-by: Jacob Young <[email protected]>
@adriweb
examples: add c++ tireal monte-carlo pi example.
88875d6
@adriweb adriweb marked this pull request as ready for review November 2, 2020 00:33
@adriweb adriweb merged commit c4c0775 into llvm Nov 2, 2020
@adriweb adriweb deleted the feature/tireal branch November 2, 2020 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateoconlechuga mateoconlechuga mateoconlechuga left review comments

@debrouxl debrouxl Awaiting requested review from debrouxl

@jacobly0 jacobly0 Awaiting requested review from jacobly0

@runer112 runer112 Awaiting requested review from runer112

Assignees
No one assigned
Labels
enhancement feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adriweb @erentar @mateoconlechuga