Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_VertLine_NoClip improvements #30

Merged
merged 1 commit into from Oct 20, 2016
Merged

_VertLine_NoClip improvements #30

merged 1 commit into from Oct 20, 2016

Conversation

ghost
Copy link

@ghost ghost commented Oct 20, 2016

-modified length check : replaced "dec b" with "xor a \ or b"
-optimised a little the drawing

_VertLine_NoClip improvements
8d0bbfc 
-modified length check : replaced "dec b" with "xor a \ or b"
-optimised a little the drawing
runer112
runer112 reviewed Oct 20, 2016
View reviewed changes
Copy link
Member

@runer112 runer112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe both the fix and the optimization are correct/good. Does anyone else want to confirm, specifically about the length fix? This makes vertical lines one pixel longer, but I think they always should have been.

@mateoconlechuga mateoconlechuga merged commit 02749c4 into CE-Programming:master Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
optimization
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@runer112 @mateoconlechuga