Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/refactor headers #378

Merged
merged 26 commits into from
May 12, 2022
Merged

Feature/refactor headers #378

merged 26 commits into from
May 12, 2022

Conversation

drdnar
Copy link
Contributor

@drdnar drdnar commented Apr 24, 2022

At @mateoconlechuga's suggestion, I've refactored the giant tice.h file into smaller files. This allows finding things easier, and also prevents cluttering the global namespace with unneeded names. As a further bonus, I've written some additional documentation.

The sys/ name was Zeroko's suggestion, because sys/ is used for platform-specific functionality.

Additionally:

  • Flags now have names; see ti/flags.h. The naming convention may be debatable.
  • The different keys on the TI-83 Premium CE now have names. The names are in English, because everything else is already in English.

@drdnar drdnar temporarily deployed to Autotester April 24, 2022 03:33 Inactive
@drdnar drdnar temporarily deployed to Autotester April 24, 2022 03:33 Inactive
@drdnar drdnar temporarily deployed to Autotester April 24, 2022 03:33 Inactive
@drdnar drdnar temporarily deployed to Autotester April 24, 2022 03:33 Inactive
@drdnar drdnar temporarily deployed to Autotester April 24, 2022 03:33 Inactive
@drdnar drdnar temporarily deployed to Autotester April 24, 2022 03:33 Inactive
@drdnar drdnar temporarily deployed to Autotester April 24, 2022 03:33 Inactive
@drdnar drdnar temporarily deployed to Autotester April 24, 2022 03:33 Inactive
@drdnar drdnar temporarily deployed to Autotester April 24, 2022 03:33 Inactive
@drdnar drdnar temporarily deployed to Autotester April 24, 2022 03:33 Inactive
@drdnar drdnar temporarily deployed to Autotester April 24, 2022 03:33 Inactive
@drdnar drdnar temporarily deployed to Autotester April 24, 2022 03:33 Inactive
@drdnar drdnar temporarily deployed to Autotester May 12, 2022 02:55 Inactive
@drdnar drdnar temporarily deployed to Autotester May 12, 2022 02:55 Inactive
@drdnar drdnar temporarily deployed to Autotester May 12, 2022 02:56 Inactive
@drdnar drdnar temporarily deployed to Autotester May 12, 2022 02:56 Inactive
@drdnar drdnar temporarily deployed to Autotester May 12, 2022 02:56 Inactive
@drdnar drdnar temporarily deployed to Autotester May 12, 2022 02:56 Inactive
@drdnar drdnar temporarily deployed to Autotester May 12, 2022 02:56 Inactive
@drdnar drdnar temporarily deployed to Autotester May 12, 2022 03:13 Inactive
@drdnar drdnar temporarily deployed to Autotester May 12, 2022 03:13 Inactive
@drdnar drdnar temporarily deployed to Autotester May 12, 2022 03:13 Inactive
@drdnar drdnar temporarily deployed to Autotester May 12, 2022 03:15 Inactive
@drdnar drdnar temporarily deployed to Autotester May 12, 2022 03:15 Inactive
@drdnar drdnar temporarily deployed to Autotester May 12, 2022 03:15 Inactive
@drdnar drdnar temporarily deployed to Autotester May 12, 2022 03:15 Inactive
@drdnar drdnar temporarily deployed to Autotester May 12, 2022 03:15 Inactive
@drdnar drdnar temporarily deployed to Autotester May 12, 2022 03:15 Inactive
@drdnar drdnar temporarily deployed to Autotester May 12, 2022 03:20 Inactive
@drdnar drdnar temporarily deployed to Autotester May 12, 2022 03:20 Inactive
@drdnar drdnar temporarily deployed to Autotester May 12, 2022 03:20 Inactive
@drdnar drdnar temporarily deployed to Autotester May 12, 2022 03:20 Inactive
@drdnar drdnar temporarily deployed to Autotester May 12, 2022 03:20 Inactive
@drdnar drdnar temporarily deployed to Autotester May 12, 2022 03:20 Inactive
@mateoconlechuga mateoconlechuga dismissed runer112’s stale review May 12, 2022 03:25

all changes resolved

@mateoconlechuga mateoconlechuga merged commit 2c2a174 into master May 12, 2022
@mateoconlechuga mateoconlechuga deleted the feature/refactor-headers branch May 12, 2022 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants