Skip to content

Adding a default to dynamic property maps #7712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 5, 2024

Conversation

sloriot
Copy link
Member

@sloriot sloriot commented Sep 13, 2023

TODO

  • think about get(tag, property_map, value) that may be an issue if coded not strictly enough for some models
  • find where the doc should be added

Sorry, something went wrong.

WIP: need updates in all models of face graph
@sloriot sloriot marked this pull request as ready for review March 25, 2024 09:48
@sloriot sloriot force-pushed the BGL-dynamic_with_default branch from 32bd0ac to b13f6c0 Compare March 25, 2024 09:53
@sloriot sloriot force-pushed the BGL-dynamic_with_default branch from b13f6c0 to baf0849 Compare March 25, 2024 10:06
sloriot added 2 commits March 27, 2024 08:21
@sloriot sloriot added Batch_1 First Batch of PRs under testing Tested and removed Under Testing Ready to be tested Batch_1 First Batch of PRs under testing labels Apr 1, 2024
@sloriot
Copy link
Member Author

sloriot commented Apr 4, 2024

Successfully tested in CGAL-6.0-Ic-209

@lrineau lrineau self-assigned this Apr 5, 2024
@lrineau lrineau added this to the 6.0-beta milestone Apr 5, 2024
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Apr 5, 2024
@lrineau lrineau merged commit 4677ece into CGAL:master Apr 5, 2024
9 checks passed
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Apr 5, 2024
@lrineau lrineau deleted the BGL-dynamic_with_default branch April 5, 2024 12:30
sloriot added a commit to sloriot/cgal that referenced this pull request Jul 5, 2024
bug introduced CGAL#7712
sloriot added a commit that referenced this pull request Dec 4, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Follow up of  #7712
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants