Fixing ICPC usage with modern cmake and wrappers

.github/ISSUE_TEMPLATE.md → .github/ISSUE_TEMPLATE/ISSUE_TEMPLATE.md

@@ -1,3 +1,11 @@
+---
+name: Issue
+about: Use this template for reporting issues with CGAL
+title: ''
+labels: ''
+assignees: ''
+---
+
 _Please use the following template to help us solving your issue._
 
 ## Issue Details

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1 @@
+blank_issues_enabled: false

.github/workflows/reuse.yml

@@ -10,17 +10,18 @@ jobs:
   reuse:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v4
-    - name: REUSE version
-      uses: fsfe/reuse-action@v4
+    - name: Checkout
+      uses: actions/checkout@v4
+    - name: Display reuse-tool version
+      uses: fsfe/reuse-action@v5
       with:
         args: --version
-    - name: REUSE lint
-      uses: fsfe/reuse-action@v4
+    - name: REUSE Compliance Check
+      uses: fsfe/reuse-action@v5
       with:
         args: --include-submodules lint
     - name: REUSE SPDX SBOM
-      uses: fsfe/reuse-action@v4
+      uses: fsfe/reuse-action@v5
       with:
         args: spdx
     - name: install dependencies
@@ -29,7 +30,7 @@ jobs:
       run: |
         mkdir -p ./release
         cmake -DDESTINATION=./release -DCGAL_VERSION=9.9 -P ./Scripts/developer_scripts/cgal_create_release_with_cmake.cmake
-    - name: REUSE lint release tarball
-      uses: fsfe/reuse-action@v4
+    - name: REUSE Compliance Check of release tarball
+      uses: fsfe/reuse-action@v5
       with:
         args: --root ./release/CGAL-9.9 --include-submodules lint

AABB_tree/demo/AABB_tree/CMakeLists.txt

@@ -14,7 +14,7 @@ find_package(Qt6 QUIET COMPONENTS Gui OpenGL)
 
 if(CGAL_Qt6_FOUND AND Qt6_FOUND)
 
-  add_definitions(-DQT_NO_KEYWORDS)
+  add_compile_definitions(QT_NO_KEYWORDS)
 
   # Instruct CMake to run moc/ui/rcc automatically when needed.
   set(CMAKE_AUTOMOC ON)

Algebraic_kernel_d/doc/Algebraic_kernel_d/Algebraic_kernel_d.txt

@@ -10,7 +10,7 @@ namespace CGAL {
 \section Algebraic_kernel_dIntroduction Introduction
 
 Real solving of polynomials is a fundamental problem with a wide application range.
-This package is targeted at providing black-box implementations of state-of-the-art
+This package provides black-box implementations of
 algorithms to determine, compare, and approximate real roots of univariate polynomials
 and bivariate polynomial systems. Such a black-box is called an *Algebraic Kernel*.
 Since this package is aimed at providing more than one implementation, the interface of
@@ -283,41 +283,6 @@ is not stored internally in terms of an `Algebraic_real_1` object.
 Querying such a representation by calling `Compute_y_2` is a
 time-consuming step, and should be avoided for efficiency reasons if possible.
 
-\subsection Algebraic_kernel_dAlgebraicKernelsBasedon Algebraic Kernels Based on RS
-
-The package offers two univariate algebraic kernels that are based on
-the library RS \cgalCite{cgal:r-rs}, namely `Algebraic_kernel_rs_gmpz_d_1`
-and `Algebraic_kernel_rs_gmpq_d_1`. As the names indicate,
-the kernels are based on the library RS \cgalCite{cgal:r-rs} and support univariate
-polynomials over `Gmpz` or `Gmpq`, respectively.
-
-In general we encourage to use `Algebraic_kernel_rs_gmpz_d_1`
-instead of `Algebraic_kernel_rs_gmpq_d_1`. This is caused by
-the fact that the most efficient way to compute operations (such as gcd)
-on polynomials with rational coefficients is to use the corresponding
-implementation for polynomials with integer coefficients. That is,
-the `Algebraic_kernel_rs_gmpq_d_1` is slightly slower due to
-overhead caused by the necessary conversions. However, since this may
-not always be a major issue, the `Algebraic_kernel_rs_gmpq_d_1`
-is provided for convenience.
-
-The core of both kernels is the implementation of the interval Descartes
-algorithm \cgalCite{cgal:rz-jcam-04} of the library RS \cgalCite{cgal:r-rs},
-which is used to isolate the roots of the polynomial.
-The RS library restricts its attention to univariate integer
-polynomials and some substantial gain of efficiency can be made by using a kernel
-that does not follow the generic programming paradigm, by avoiding
-interfaces between layers. Specifically, working with
-only one number type allows to optimize some polynomial operations
-as well as memory handling. The implementation of these kernels
-make heavy use of the \mpfr \cgalCite{cgal:mt-mpfr} and \mpfi \cgalCite{cgal:r-mpfi}
-libraries, and of their \cgal interfaces, `Gmpfr` and `Gmpfi`.
-The algebraic numbers (roots of the polynomials) are represented
-in the two RS kernels by a `Gmpfi` interval and a pointer to
-the polynomial of which they are roots. See \cgalCite{cgal:lpt-wea-09}
-for more details on the implementation, tests of these kernels,
-comparisons with other algebraic kernels and discussions about the
-efficiency.
 
 \section Algebraic_kernel_dExamples Examples
 
@@ -376,12 +341,13 @@ Michael Hemmer and Michael Kerber, respectively. Notwithstanding, the authors al
 contribution of all authors of the \exacus project,
 particularly the contribution of Arno Eigenwillig, Sebastian Limbach and Pavel Emeliyanenko.
 
-The two univariate kernels that interface the library RS \cgalCite{cgal:r-rs} were
-written by Luis Peñaranda and Sylvain Lazard.
+In 2010, two univariate kernels that interface the library RS \cgalCite{cgal:r-rs} were
+written by Luis Peñaranda and Sylvain Lazard \cgalCite{cgal:2009-ESA}.
 Both models interface the library RS \cgalCite{cgal:r-rs} by Fabrice Rouillier.
 The authors want to thank Fabrice Rouillier and Elias Tsigaridas for
 strong support and many useful discussions that lead to the integration of RS.
+Due to lack of maintenance, these kernels have been removed in 2024.
+
 
 */
 } /* namespace CGAL */
-

Algebraic_kernel_d/doc/Algebraic_kernel_d/Concepts/AlgebraicKernel_d_1.h

@@ -9,8 +9,7 @@ algebraic functionalities on univariate polynomials of general degree \f$ d\f$.
 \cgalRefines{CopyConstructible,Assignable}
 
 \cgalHasModelsBegin
-\cgalHasModels{CGAL::Algebraic_kernel_rs_gmpz_d_1}
-\cgalHasModels{CGAL::Algebraic_kernel_rs_gmpq_d_1}
+\cgalHasModels{CGAL::Algebraic_kernel_d_1}
 \cgalHasModelsEnd
 
 \sa `AlgebraicKernel_d_2`
@@ -172,4 +171,3 @@ AlgebraicKernel_d_1::Bound_between_1 bound_between_1_object() const;
 /// @}
 
 }; /* end AlgebraicKernel_d_1 */
-

Algebraic_kernel_d/doc/Algebraic_kernel_d/Concepts/AlgebraicKernel_d_2.h

@@ -8,6 +8,11 @@ for solving and handling bivariate polynomial systems of general degree \f$ d\f$
 
 \cgalRefines{AlgebraicKernel_d_1,CopyConstructible,Assignable}
 
+
+\cgalHasModelsBegin
+\cgalHasModels{CGAL::Algebraic_kernel_d_2}
+\cgalHasModelsEnd
+
 \sa `AlgebraicKernel_d_1`
 
 */
@@ -176,4 +181,3 @@ AlgebraicKernel_d_2::Bound_between_x_2 bound_between_x_2_object() const;
 /// @}
 
 }; /* end AlgebraicKernel_d_2 */
-

Algebraic_kernel_d/doc/Algebraic_kernel_d/PackageDescription.txt

@@ -21,12 +21,11 @@
 \cgalPkgPicture{Algebraic_kernel_d.png}
 \cgalPkgSummaryBegin
 \cgalPkgAuthors{Eric Berberich, Michael Hemmer, Michael Kerber, Sylvain Lazard, Luis Peñaranda, and Monique Teillaud}
-\cgalPkgDesc{Real solving of polynomials is a fundamental problem with a wide application range.  This package is targeted to provide black-box implementations of state-of-the-art  algorithms to determine, compare and approximate real roots of univariate polynomials and bivariate polynomial systems. Such a black-box is called an *Algebraic %Kernel*.  So far the package only provides models for the univariate kernel. Nevertheless,  it already defines concepts for the bivariate kernel, since this settles the interface for upcoming implementations.}
+\cgalPkgDesc{Real solving of polynomials is a fundamental problem with a wide application range.  This package is targeted to provide black-box implementation  algorithms to determine, compare and approximate real roots of univariate polynomials and bivariate polynomial systems. Such a black-box is called an *Algebraic %Kernel*.  So far the package only provides models for the univariate kernel. Nevertheless,  it already defines concepts for the bivariate kernel, since this settles the interface for upcoming implementations.}
 \cgalPkgManuals{Chapter_Algebraic_Kernel,PkgAlgebraicKernelDRef}
 \cgalPkgSummaryEnd
 \cgalPkgShortInfoBegin
 \cgalPkgSince{3.6}
-\cgalPkgDependsOn{Some models depend on \ref thirdpartyRS3.}
 \cgalPkgBib{cgal:bht-ak}
 \cgalPkgLicense{\ref licensesLGPL "LGPL"}
 \cgalPkgShortInfoEnd
@@ -100,8 +99,4 @@
 - `CGAL::Algebraic_kernel_d_1<Coeff>`
 - `CGAL::Algebraic_kernel_d_2<Coeff>`
 
-- `CGAL::Algebraic_kernel_rs_gmpz_d_1`
-- `CGAL::Algebraic_kernel_rs_gmpq_d_1`
-
 */
-

Algebraic_kernel_d/include/CGAL/Algebraic_kernel_d/Curve_analysis_2.h

@@ -520,7 +520,7 @@ class Curve_analysis_2 : public ::CGAL::Handle_with_policy< Rep_ > {
     void set_event_lines(InputIterator1 event_begin,
                          InputIterator1 event_end,
                          InputIterator2 intermediate_begin,
-                         InputIterator2 CGAL_precondition_code(intermediate_end)) const {
+                         InputIterator2 CGAL_assertion_code(intermediate_end)) const {
 
         if(! this->ptr()->event_coordinates) {
 

Algebraic_kernel_d/include/CGAL/Algebraic_kernel_d/Curve_pair_analysis_2.h

@@ -875,7 +875,7 @@ class Curve_pair_analysis_2 :
      * Checks intersection with symbolic methods
      */
     bool check_candidate_symbolically(Status_line_CA_1& e1,size_type ,
-                                      Status_line_CA_1& CGAL_precondition_code(e2),size_type ,
+                                      Status_line_CA_1& CGAL_assertion_code(e2),size_type ,
                                       size_type k) const {
         Polynomial_1 p = -coprincipal_subresultants(k-1);
         Polynomial_1 q = principal_subresultants(k)*Coefficient(k);
@@ -1173,7 +1173,7 @@ class Curve_pair_analysis_2 :
     /*
      * \brief reduces the number of possible intersections
      *
-     * At the position given by the event lins \c e1 and \c e2 and the slice
+     * At the position given by the event lines \c e1 and \c e2 and the slice
      * info object \c slice, the points on the event lines are further refined
      * until there are only \c n possible intersection points. The method can
      * be interrupted if all possible intersection points are known to have

Algebraic_kernel_d/include/CGAL/Algebraic_kernel_d/Real_roots.h

@@ -65,7 +65,7 @@ template < class PolynomialIterator,
 int gen_agebraic_reals_with_mults( PolynomialIterator           fac,
                                    PolynomialIterator           fac_end,
                                    IntIterator                  mul,
-                                   IntIterator                  CGAL_precondition_code(mul_end),
+                                   IntIterator                  CGAL_assertion_code(mul_end),
                                    AlgebraicRealOutputIterator  oi_root,
                                    IntOutputIterator            oi_mult){
 

Algebraic_kernel_d/include/CGAL/Algebraic_kernel_d/Status_line_CPA_1.h

@@ -331,7 +331,7 @@ class Status_line_CPA_1 :
                              const typename Curve_pair_analysis_2
                                  ::Curve_analysis_2& c1,
                              const typename Curve_pair_analysis_2
-                                 ::Curve_analysis_2& CGAL_precondition_code(c2)) const
+                                 ::Curve_analysis_2& CGAL_assertion_code(c2)) const
     {
 
         CGAL_precondition(0 <= j && j < number_of_events());