Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ability to handle multiple config files #494

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Jul 29, 2020

Address Issue #486

Allow support for multiple config files

set_config("--config")->expected(1, 3);

will allow upto expected max config files.

@phlptp phlptp added this to the v2.0 milestone Jul 29, 2020
@phlptp
Copy link
Collaborator Author

phlptp commented Jul 29, 2020

  • update docs
  • verify formatting and coverage

@phlptp phlptp force-pushed the multi_config_support branch 7 times, most recently from 0659ebd to a997925 Compare July 29, 2020 15:49
@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #494 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #494   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines         3729      3731    +2     
=========================================
+ Hits          3729      3731    +2     
Impacted Files Coverage Δ
include/CLI/App.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82c71bd...921dc3d. Read the comment docs.

@phlptp phlptp changed the title Add an ability to deal handle multiple config files Add an ability to handle multiple config files Aug 5, 2020
@phlptp phlptp force-pushed the multi_config_support branch from a997925 to f17d25d Compare August 17, 2020 22:12
@phlptp phlptp force-pushed the multi_config_support branch from f17d25d to 921dc3d Compare August 17, 2020 22:14
@phlptp
Copy link
Collaborator Author

phlptp commented Aug 17, 2020

@henryiii I think this is ready now

Copy link
Collaborator

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! One bool -> auto I'm not really fond of, but it's okay.

@henryiii henryiii merged commit 6aa58d5 into CLIUtils:master Sep 3, 2020
@henryiii henryiii deleted the multi_config_support branch September 3, 2020 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants