Remove invalid triangles from north and south pole of EllipsoidGeometry #3645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 from me. I also checked out some different materials as well and everything is working as expected and a big improvement over master. Does anyone else want to review this? If not I'll merge later tonight. |
mramato
added a commit
that referenced
this pull request
Mar 1, 2016
Remove invalid triangles from north and south pole of EllipsoidGeometry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3045
There wasn't actually a hole in the ellipsoid; the shading for the top slice (and bottom slice, I presume) was off because the normal vector had NaNs due to adjacent triangles with no area.
So this PR removes a bunch of triangles being added with two corners at the same position.
The top and bottom of the ellipsoid needed to be triangulated with a fan instead of a strip.