Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reasoning for OpenRouter using OpenAI provider #6251

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

xsun2001
Copy link

@xsun2001 xsun2001 commented Feb 18, 2025

πŸ’» ε˜ζ›΄η±»εž‹ | Change Type

  • feat
  • fix
  • refactor
  • perf
  • style
  • test
  • docs
  • ci
  • chore
  • build

πŸ”€ ε˜ζ›΄θ―΄ζ˜Ž | Description of Change

  • Add include_reasoning = true in chat request payload for openrouter
  • Using delta.reasoning instead of delta.reasoning_content for openrouter
  • Optimize reasoning display style to include all reasoning text in one single quote block

πŸ“ θ‘₯充俑息 | Additional Information

Summary by CodeRabbit

  • New Features

    • Chat interactions now include enriched contextual details in responses when using "openrouter.ai", enhancing user insights.
  • Style

    • Improved live message formatting ensures a clearer and more consistent display during active processing, resulting in a smoother and more engaging user experience.

Copy link

vercel bot commented Feb 18, 2025

@xsun2001 is attempting to deploy a commit to the NextChat Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Feb 18, 2025

Walkthrough

The changes modify three key files. In app/client/platforms/openai.ts, imports have been reorganized to include new constants and modules, and the chat method in the ChatGPTApi class now conditionally adds a reasoning flag based on the request path. The app/utils/chat.ts file sees the repositioning of the UPLOAD_URL constant and updates to the streaming functions for consistent newline formatting during thinking mode. In app/api/common.ts, a new mechanism for modifying the request payload based on the baseUrl is introduced, enhancing request handling.

Changes

File(s) Change Summary
app/client/platforms/openai.ts Reorganized imports (added Azure and repositioned OPENAI_BASE_URL); updated chat method to check if chatPath contains "openrouter.ai" and include include_reasoning accordingly; refined extraction and handling of reasoning in response; adjusted streamWithThink callback for new choices structure.
app/utils/chat.ts Moved UPLOAD_URL constant; updated stream and streamWithThink functions to consistently prefix newlines with "> " during thinking mode and simplified content formatting.
app/api/common.ts Introduced a mechanism to modify request payloads based on the baseUrl containing "openrouter.ai"; streamlined request body parsing.

Possibly related PRs

  • 1Β #6289: The changes in the main PR are related to those in the retrieved PR as both involve modifications to the app/api/common.ts file, specifically regarding the handling of request payloads and the addition of properties based on certain conditions.

Poem

I'm a little rabbit, hopping through the code,
Rearranging imports on a winding road.
Chat paths checked with a keen, alert eye,
Reasoning flags set as messages fly.
With every line and every thoughtful tweak,
We dance in the rhythmβ€”our code unique!
πŸ₯•πŸ‡


πŸ“œ Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 6e082ad and a87ec75.

πŸ“’ Files selected for processing (2)
  • app/api/common.ts (3 hunks)
  • app/client/platforms/openai.ts (8 hunks)
πŸ”‡ Additional comments (5)
app/api/common.ts (3)

93-100: Efficient enhancement for OpenRouter reasoning capabilities

This addition to modify the request payload for OpenRouter is well implemented. It correctly adds the include_reasoning parameter to enable reasoning functionality specifically for OpenRouter requests.


111-111: Using the modified payload in fetchOptions

This change correctly uses the newly processed payload in the fetch request.


122-122: Consistent use of modified payload for model validation

Good consistency in using the same modified payload for model validation.

app/client/platforms/openai.ts (2)

298-303: Well-documented client-side implementation for OpenRouter reasoning

The implementation to add include_reasoning: true for OpenRouter on the client side is clean and properly documented. The comment explains the purpose and links to the relevant documentation, which is excellent practice.


346-349: Robust handling of different reasoning response formats

This change elegantly handles both the old (reasoning_content) and new (reasoning) response formats, ensuring backward compatibility while supporting the updated structure from OpenRouter.

✨ Finishing Touches
  • πŸ“ Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@xsun2001
Copy link
Author

xsun2001 commented Mar 7, 2025

Hi, is there anyone to review this pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant