Fix CommonSpaces and MPI #2176
Merged
Fix CommonSpaces and MPI #2176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
force-pushed
the
gb/common_mpi
branch
4 times, most recently
from
19f1a7f to
a7ec52d
Compare
4 tasks
Sbozzolo
force-pushed
the
gb/common_mpi
branch
from
a7ec52d to
10dcf4d
Compare
Sbozzolo
force-pushed
the
gb/common_mpi
branch
from
10dcf4d to
59bc0f4
Compare
Comment on lines
+81
to
+82
| # Column spaces are not supported with MPI | ||
| if !(ClimaComms.context() isa ClimaComms.MPICommsContext) |
There was a problem hiding this comment.
Does this just not work?
There was a problem hiding this comment.
I had this error:
AssertionError: Columns can only be created on Singleton contextes.
But maybe it's because I am not caught up to main. Let me try rebasing
There was a problem hiding this comment.
Actually, I added that @assert. I'll verify again
There was a problem hiding this comment.
I added the assert because creating columns in MPI settings is not possible:
ClimaCore.jl/src/Topologies/interval.jl
Line 46 in c19162a
There was a problem hiding this comment.
Here's the failing build: https://buildkite.com/clima/climacore-ci/builds/5255
charleskawczynski
approved these changes
Feb 13, 2025
Sbozzolo
force-pushed
the
gb/common_mpi
branch
3 times, most recently
from
0c105bc to
76896fd
Compare
The `CommonGrids` module passes down the context to all the grid it creates. This is a problem for IntervalTopology, because it can only be created with Singletons. This commit fixes this issue and adds test checking that we can create CommonSpaces with MPI and CUDA
Sbozzolo
force-pushed
the
gb/common_mpi
branch
from
76896fd to
d9957d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CommonGridsmodule passes down the context to all the grid it creates. This is a problem for IntervalTopology, because it can only be created with Singletons.This commit fixes this issue and adds test checking that we can create CommonSpaces with MPI and CUDA
Closes #2175