Dont materialize bc expr with uninitialized data #2253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/similar
branch
from
53e8857 to
3b556c6
Compare
Sbozzolo
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
DebugOnlymodule to find NaNs, I'm finding that we're executing Broadcast expressions inImplicitEquationJacobiandue topreconditioner_cache. Per its doc string, it's role is not to initialize data, but only to allocate data, so I think usingsimilarhere is more appropriate, as the broadcast expression may contain uninitialized data. To do this, I've addedsimilarsupport on Broadcasted objects with field and stencil styles.I think it's pretty clear that we either need to fix the doc string, or fix the code, because they are inconsistent.