-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resurrect indexHint function. #21304
Conversation
a13982b
to
c29e4f2
Compare
Integration tests (thread) — fail: 1, passed: 1040, error: 24
|
Maybe also add some test case from linked issue? |
0 0 0 | ||
0 1 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amosbird but why it returns the first row too for select * from tbl WHERE indexHint(t = 1) order by t
with index_granularity=1
?
P.S. it worth converting this test to use -- { echo }
test hint, see https://github.com/ClickHouse/ClickHouse/blob/master/tests/queries/0_stateless/01564_test_hint_woes.sql for example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but why it returns the first row too for select * from tbl WHERE indexHint(t = 1) order by t with index_granularity=1
It's how primary index work in clickhouse. The current granule starts with value 1 doesn't mean all values in previous granule < 1
Sure. Tests are added. |
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add back
indexHint
function. This is for #21238 . This reverts #9542 . This fixes #9540 .Detailed description / Documentation draft:
.