-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YAML Configuration for ClickHouse #21858
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d35783f
to
ca2bdc3
Compare
vitlibar
reviewed
Apr 13, 2021
I've moved YAML to XML translation function into a separate class and corrected the code in ConfigProcessor.cpp, the code looks better overall. |
0ad2abb
to
7546f06
Compare
.../integration/test_yaml_configuration/configs/clickhouse_main_xml/config.d/more_clusters.yaml
Outdated
Show resolved
Hide resolved
Looks like it will fix #3607 |
users: | ||
default: | ||
networks: | ||
~replace: replace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tab
vitlibar
reviewed
May 11, 2021
vitlibar
reviewed
May 11, 2021
vitlibar
reviewed
May 14, 2021
vitlibar
reviewed
May 14, 2021
vitlibar
reviewed
May 14, 2021
vitlibar
reviewed
May 14, 2021
vitlibar
reviewed
May 14, 2021
vitlibar
reviewed
May 14, 2021
vitlibar
reviewed
May 14, 2021
vitlibar
reviewed
May 17, 2021
Why have you changed |
vitlibar
reviewed
May 17, 2021
vitlibar
reviewed
May 18, 2021
vitlibar
reviewed
May 18, 2021
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
May 30, 2021
I'm using such hack to hide the password: $ clickhouse-client --config <(echo '<config><password></password></config>') But this had been broken in ClickHouse#21858 v2: add a test v3: fail for unsupported extensions
danlark1
reviewed
Jun 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-feature
Pull request with new product feature
submodule changed
At least one submodule changed in this PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added YAML configuration support to configuration loader. This closes #3607.