Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CPU-dependent behaviour in tests #22590

Merged
merged 1 commit into from
Apr 4, 2021
Merged

Fix CPU-dependent behaviour in tests #22590

merged 1 commit into from
Apr 4, 2021

Conversation

alexey-milovidov
Copy link
Member

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Adjust some tests to output identical results on amd64 and aarch64 (qemu). The result was depending on implementation specific CPU behaviour.

Details:

$ clickhouse-local --query "SELECT toInt32(72004899337.38588)"
-2147483648
$ qemu-aarch64-static clickhouse-aarch64-2 local --query "SELECT toInt32(72004899337.38588)"
<jemalloc>: MADV_DONTNEED does not work (memset will be used instead)
<jemalloc>: (This is the expected behaviour if you are running under QEMU)
2147483647

@robot-clickhouse robot-clickhouse added the pr-build Pull request with build/testing/packaging improvement label Apr 4, 2021
@alexey-milovidov alexey-milovidov self-assigned this Apr 4, 2021
@alexey-milovidov alexey-milovidov merged commit f6e6842 into master Apr 4, 2021
@alexey-milovidov alexey-milovidov deleted the fix-tests-aarch64 branch April 4, 2021 12:43
@alexey-milovidov alexey-milovidov mentioned this pull request Apr 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexey-milovidov alexey-milovidov

Labels
pr-build Pull request with build/testing/packaging improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexey-milovidov @robot-clickhouse