Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed function ngrams when string contains utf8 characters #31706

Merged
merged 2 commits into from
Nov 26, 2021
Merged

Fixed function ngrams when string contains utf8 characters #31706

merged 2 commits into from
Nov 26, 2021

Conversation

yandd
Copy link
Contributor

@yandd yandd commented Nov 24, 2021 •
edited by vdimir
Loading

Changelog category:

  • Bug Fix (user-visible misbehaviour in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Fixed function ngrams when string contains utf8 characters

Detailed description / Documentation draft:
...

@robot-clickhouse robot-clickhouse added doc-alert pr-feature Pull request with new product feature pr-bugfix Pull request with bugfix, not backported by default and removed pr-feature Pull request with new product feature labels Nov 24, 2021
@vdimir vdimir assigned vdimir and unassigned vdimir Nov 24, 2021
@vdimir
Copy link
Member

vdimir commented Nov 24, 2021

Could you add test for problem cases?

@yandd
Copy link
Contributor Author

yandd commented Nov 25, 2021

Could you add test for problem cases?

Added already.

@vdimir vdimir self-assigned this Nov 25, 2021
@vdimir
Copy link
Member

vdimir commented Nov 25, 2021

ref #29738 (comment)

vdimir
vdimir approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@vdimir vdimir left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vdimir vdimir merged commit 41c9067 into ClickHouse:master Nov 26, 2021
This was referenced Nov 26, 2021
Closed
Closed
Merged
Closed
Closed
robot-clickhouse pushed a commit that referenced this pull request Nov 26, 2021
Backport #31706 to 21.11: Fixed function ngrams when string contains …
9f7447a 
…utf8 characters
@robot-clickhouse robot-clickhouse mentioned this pull request Nov 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdimir vdimir vdimir approved these changes

Assignees

@vdimir vdimir

Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yandd @vdimir @robot-clickhouse