please merge this change into your main it is veryhelpfull for me if you mergee the changes #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@muneswar748 why you have to reduce it to 9 seconds ? FileWatcher should work upon file changed |
|
The actual purpose of this PR was to make the file interval configurable. Based on my observation of this (excellent) library's file watcher class, a non-config tree folder only gets examined at the file watcher interval (90 seconds). In our particular deployment, the symbolic link logic does not execute. Hence why the request to make the folder / filesystem watcher configurable. |
|
Making it configurable makes sense, so it could by dynamic rather than fixed 90s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.