Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow STRING link to connect to converted COMBO socket #3236

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

huchenlei
Copy link
Member

@huchenlei huchenlei commented Mar 25, 2025

image

As COMBO widget is essentially selecting a specific string from a set of strings, we should allow connection of STRING link to converted COMBO socket for more dynamic workflow manipulation, i.e. dynamically generate a COMBO input option from other nodes.

┆Issue is synchronized with this Notion page by Unito

@huchenlei huchenlei requested a review from a team as a code owner March 25, 2025 19:43
@huchenlei
Copy link
Member Author

Ref: If invalid combo value is passed at runtime, the backend will report error:

image

@huchenlei huchenlei marked this pull request as draft March 25, 2025 20:07
@JorgeR81
Copy link

JorgeR81 commented Mar 26, 2025

So, we could just connect a "String" node and it would get the COMBO list, automatically ?

And if we unplug the wire, would the node still "remember" the COMBO list ?

If the COMBO list it's not "forgotten", it may be possible to then connect cg-use-everywhere nodes, right ?


Example:

It would work like this "Preprocessor Selector" node, in comfyui_controlnet_aux.
This node was added essentially to work with cg-use-everywhere.

It's meant to replace the Primitive COMBO, which cannot be connected to cg-use-everywhere nodes.
Fannovel16/comfyui_controlnet_aux#291

This means that ComfyUI would create these type of nodes automatically, as needed ?

sel

@huchenlei
Copy link
Member Author

There are some backend logic change required, as currently converted combo type socket is not being correctly validated in the backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants