Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fields type to FmtOptions #320

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Add fields type to FmtOptions #320

merged 2 commits into from
Jun 25, 2024
+1 −0

Conversation

mocca102
Copy link
Contributor

@mocca102 mocca102 commented Jun 5, 2024

No description provided.

@mocca102
Add fields type tp FmtOptions
Loading
Loading status checks…
ede7555
@mocca102 mocca102 requested a review from a team June 5, 2024 10:44
@mocca102 mocca102 mentioned this pull request Jun 5, 2024
Closed
stanlp1
stanlp1 requested changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@stanlp1 stanlp1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mocca102 Where is this returned?

I don't see fields under fmtOptions. I think it might be under the base request. Also, should it be optional.

Edit: Nvm I see the original issue, this is for the parameters.

stanlp1
stanlp1 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@stanlp1 stanlp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But let's make it optional.

@mocca102
Make fields optional
Loading
Loading status checks…
cd80c2a
@esezen esezen merged commit 1e120dc into master Jun 25, 2024
7 checks passed
@esezen esezen deleted the noci-add-fmt-options-fields-type branch June 25, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanlp1 stanlp1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mocca102 @stanlp1 @esezen