Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NOCSL] Migrate to v2 search result load #362

Merged
merged 5 commits into from
Dec 19, 2024
Merged

[NOCSL] Migrate to v2 search result load #362

merged 5 commits into from
Dec 19, 2024

Conversation

stanlp1
Copy link
Contributor

@stanlp1 stanlp1 commented Dec 17, 2024

No description provided.

@stanlp1 stanlp1 requested a review from a team December 17, 2024 21:54
jjl014
jjl014 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@jjl014 jjl014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are looking great from what I can tell!

Just left one minor comment on one of the tests being removed.

@jjl014 jjl014 requested a review from a team December 18, 2024 00:50
@esezen esezen merged commit bc6c0aa into master Dec 19, 2024
8 checks passed
@esezen esezen deleted the nocsl-prep-v2-migration branch December 19, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjl014 jjl014 jjl014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stanlp1 @jjl014 @esezen