Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI-3692] Update labels type #140

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Conversation

esezen
Copy link
Contributor

@esezen esezen commented Jul 22, 2024

No description provided.

@esezen esezen requested a review from a team July 22, 2024 14:13
Copy link
Contributor

@jjl014 jjl014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me!

I should have mentioned this in the story description, but It might be worth updating one of the JSON resources to add labels where the values can be a nested object and adding an additional test around that. For example:

  "results": [
    {
      "labels": {
              "__cnstrc_new_arrivals": { "display_name": "New Arrival", ...},
              "__cnstrc_best_sellers": { "display_name": "Bestseller", ...},
              "__cnstrc_trending_now": { "display_name": "Trending Now", ...}
            },
    }, ...
  ]

esezen added 3 commits August 7, 2024 22:08
@esezen esezen requested a review from jjl014 August 8, 2024 11:27
Copy link
Contributor

@jjl014 jjl014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Thanks for making the updates and sorry for not getting back to you sooner! 😓

@jjl014
Copy link
Contributor

jjl014 commented Aug 22, 2024

@esezen We may want to hold off on shipping this for now. I think we may want to bundle this change as a major version along with changes we want to make to the Tasks to return task information instead of just a boolean.

@jjl014 jjl014 merged commit b5c554c into master Sep 24, 2024
1 of 2 checks passed
@jjl014 jjl014 deleted the ci-3692-java-sdk-update-labels-type branch September 24, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants