Refactor Suggestions components for clarity #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esezen
reviewed
Nov 6, 2024
|
|
||
| // eslint-disable-next-line func-names | ||
| const DefaultRenderSectionItemsList: RenderSectionItemsList = function ({ section }) { | ||
| const { getSectionProps } = useContext(CioAutocompleteContext); |
There was a problem hiding this comment.
Since you already created a new hook, should we use it here? useCioAutocompleteContext
| const DefaultRenderSectionItemsList: RenderSectionItemsList = function ({ section }) { | ||
| const { getSectionProps } = useContext(CioAutocompleteContext); | ||
| const { displayName } = section; | ||
| const sectionTitle = camelToStartCase(displayName || getSectionTitle(section)); |
There was a problem hiding this comment.
I think we don't want to run displayName through camelToStartCase. If the user set it to be camelcase, we should leave it as is
| highlightSearchTerm, | ||
| }: SectionItemTextProps) { | ||
| export default function SectionItemText({ item, highlightSearchTerm }: SectionItemTextProps) { | ||
| const { query } = useCioAutocompleteContext(); |
There was a problem hiding this comment.
Q: Any reason why we don't move displaySearchTermHighlights here and stop passing it around?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces no logic changes. It's just organizing code into Components for clarity.
Before
SectionItemAfter
Added
useCioAutocompleteContextto make it clear what context is being used