Fix cio js client events not firing #205
Open
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug is that currently, you can’t listen to any of the dispatched events from the ConstructorIO client. Basically, this does not work.
window.addEventListener('cio.client.autocomplete.getAutocompleteResults.completed', () => {});
This line is the reason. waitForBeacon is true by default. Because we don’t load the beacon on OS UI AC the eventDispatcher remains inactive (active = false)
To fix the bug we just need to pass this to the cio instance
To test the changes add this anywhere