Skip to content

Fix custom blur #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

Fix custom blur #206

merged 1 commit into from
Apr 16, 2025

Conversation

mocca102
Copy link
Contributor

🐛 The bug

  • The custom blur hook breaks the click events if and only uf autocompleteClassName consists of multiple class names, ie

    • cio-autocomplete custom-autocomplete-styles

🔁 How to reproduce the bug?

  • Selects are broken on the full featured example since it has

    • autocompleteClassName = 'cio-autocomplete custom-autocomplete-styles';

The fix

  • Handle multiple class names by splitting and joining them again

@mocca102 mocca102 requested a review from a team as a code owner April 15, 2025 22:40
Copy link
Contributor

@Mudaafi Mudaafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I don't like how we're relying on a prop called autocompleteClassName to handle blurring since it's not intuitive if they used the Hooks Approach but that's a separate discussion to have. This fix looks good to go.

@mocca102 mocca102 merged commit 10caae0 into main Apr 16, 2025
10 checks passed
@mocca102 mocca102 deleted the noci-fix-custom-blur branch April 16, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants