Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working prefix_de #434

Merged
merged 13 commits into from
Sep 24, 2021
Merged

Working prefix_de #434

merged 13 commits into from
Sep 24, 2021

Conversation

maurolacy
Copy link
Contributor

@maurolacy maurolacy commented Sep 18, 2021

#432 follow-up. This separate PR implements / fixes range_de for a prefix_de.

@maurolacy maurolacy mentioned this pull request Sep 18, 2021
14 tasks
@maurolacy maurolacy force-pushed the 198-better-range-prefix branch from e38738c to 6d3b05d Compare September 19, 2021 19:30
@maurolacy maurolacy force-pushed the 198-prefix-de branch 2 times, most recently from aea0622 to 5e50f15 Compare September 19, 2021 20:10
@maurolacy maurolacy force-pushed the 198-better-range-prefix branch from 6d3b05d to dd186b0 Compare September 19, 2021 23:18
@maurolacy
Copy link
Contributor Author

Aand... fixed.

@maurolacy maurolacy mentioned this pull request Sep 20, 2021
@maurolacy maurolacy changed the base branch from 198-better-range-prefix to range-no-prefix September 20, 2021 06:22
@maurolacy maurolacy changed the base branch from range-no-prefix to 198-better-range-prefix September 20, 2021 06:22
@ethanfrey ethanfrey added this to the v0.10.0 milestone Sep 20, 2021
@ethanfrey
Copy link
Member

I see conflicting files. Seems it needs a rebase or merge or something.

@maurolacy
Copy link
Contributor Author

Will fix / re-implement asap.

@ueco-jb
Copy link
Contributor

ueco-jb commented Sep 22, 2021

Will fix / re-implement asap.

Just remember you're on vacations

@maurolacy
Copy link
Contributor Author

Merging this into #432's branch, for ease of rebasing.

@maurolacy maurolacy merged commit fbd5a07 into 198-better-range-prefix Sep 24, 2021
@maurolacy maurolacy deleted the 198-prefix-de branch September 24, 2021 06:45
@maurolacy
Copy link
Contributor Author

Will fix / re-implement asap.

Just remember you're on vacations

Yeah, I know. I just can't help myself. Left this half-way through, and now can't avoid keeping an eye on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants