Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of Factory Methods from Experiment API #581

Merged
merged 9 commits into from
Jun 3, 2024

Conversation

juliaputko
Copy link
Contributor

No description provided.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
addaleax Anna Henningsen
Copy link
Contributor

@amandarichardsonn amandarichardsonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

juliaputko and others added 8 commits May 28, 2024 14:01

Verified

This commit was signed with the committer’s verified signature. The key has expired.
addaleax Anna Henningsen

Verified

This commit was signed with the committer’s verified signature. The key has expired.
addaleax Anna Henningsen
@juliaputko juliaputko merged commit f21b6f8 into CrayLabs:smartsim-refactor Jun 3, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants