Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove device attribute from schemas #619

Merged
merged 5 commits into from
Jun 25, 2024

Conversation

AlyssaCote
Copy link
Contributor

This PR removes device from the schemas, MessageHandler, and tests.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (mli-feature@38081da). Learn more about missing BASE report.

Current head 568806b differs from pull request most recent head 96047fa

Please upload reports for the commit 96047fa to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             mli-feature     #619   +/-   ##
==============================================
  Coverage               ?   63.50%           
==============================================
  Files                  ?       91           
  Lines                  ?     6486           
  Branches               ?        0           
==============================================
  Hits                   ?     4119           
  Misses                 ?     2367           
  Partials               ?        0           
Files Coverage Δ
.../_core/mli/infrastructure/control/workermanager.py 18.10% <ø> (ø)
smartsim/_core/mli/infrastructure/worker/worker.py 78.20% <ø> (ø)
smartsim/_core/mli/message_handler.py 76.14% <ø> (ø)

@ankona
Copy link
Contributor

ankona commented Jun 24, 2024

There is a test here that is likely silently failing because it provides an unexpected keyword arg. At minimum, you should just have to remove device=expected_device, but could also remove from the commented out tests in test_integrated_torch_worker.py, too

@AlyssaCote AlyssaCote requested a review from ankona June 24, 2024 20:21
Copy link
Contributor

@ankona ankona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlyssaCote AlyssaCote merged commit ab900b8 into CrayLabs:mli-feature Jun 25, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants