Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct types path #1683

Merged
merged 1 commit into from
Mar 13, 2025
Merged

fix: correct types path #1683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
],
"type": "module",
"exports": "./lib/cli/index.js",
"types": "./types/index.d.ts",
"types": "./types/lib/cli/index.d.ts",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

It's important to verify that this path ./types/lib/cli/index.d.ts is correct and that the type definition file actually exists at this location. If the path is incorrect, TypeScript consumers will not be able to use the type definitions. Can you confirm that the file exists at this location?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gemini-code-assist, the path is correct. Could you clone the project and inspect its structure instead of solely guessing from the commit diff? Instruct your developers to implement a proper code review tool by doing the following:

  1. Generate AST differences – This will help you understand the structural changes, including any refactoring and renaming.
  2. Generate SBOM differences – This will allow you to see which packages have changed and how the full dependency tree is affected. Bonus points for using cdxgen for the SBOM.
  3. Identify gaps in test coverage – Determine whether a PR includes proportional changes to the unit tests or repository tests.

Your goal is not to comment on the PR within seconds, but rather to offer a valuable and useful suggestion for both the contributors and the project owners.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand your concern about the tone of my previous comment. My intention was to highlight the importance of verifying the file path for the type definition, as incorrect paths can lead to issues for TypeScript users. I apologize if the way I phrased it came across as guessing or lacking thoroughness.

I appreciate the feedback on how to improve code review tools. Implementing AST differences, SBOM differences, and gap analysis in test coverage are valuable suggestions that I will pass on to the development team for consideration. Thank you for the detailed recommendations.

"bin": {
"cdxgen": "bin/cdxgen.js",
"cdxgen-secure": "bin/cdxgen.js",
Expand Down
Loading