-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add geometry drawing scripts #52
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks super useful. I will have a look about integrating it into the CI workflows after it is merged. Only nitpick is the lot of empty lines at the end of the file. :)
Suggestion: Format the whole file with black
or ruff
.
Co-authored-by: Lukas Koch <[email protected]>
Is this ready for merge now? Or do you still need to work on it for a bit? |
Bump @jdkio |
@ast0815, it says you requested changes but I don't see any. Do you have to re-review? |
Those were the changes I originally requested. Now my only question is whether or not you are done. 😄 |
Adds
draw_geometry.py
anddraw_all.sh
. The--axis
option is useful but it's a bit finicky. Sometimes the axis doesn't align with the world properly. I've given up trying to fix it. By default it's offExample output focusing on Sand: