Skip to content

Server refactor #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 20, 2018
Merged

Server refactor #4

merged 3 commits into from
May 20, 2018

Conversation

DannyBen
Copy link
Owner

@DannyBen DannyBen commented May 20, 2018 •
edited
Loading

Refactor everything for better fitness to Madman's purpose.

  • Now support both serve and preview commands - the former is intended to serve the entire folder, a la Madness
  • Switched from using our home made templating system, to using slim
  • RTL documents are now automatically detected
  • Initial classes for the upcoming navigation / TOC features
  • Improvements to how we use and configure Sinatra - now without the ugly Server::options method + server is now starting its journey at ServerBase
  • Separate rspec fixtures to a different folder (approvals)
  • The madman render command no longer includes CSS and stuff - we might reintroduce this in the near future
  • Switch to using GitHub CSS from CDN in both the serve and preview commands
  • Specs were all adjusted to pass, but coverage has dropped to 91%

@DannyBen DannyBen merged commit 251578f into master May 20, 2018
@DannyBen DannyBen deleted the docdir branch May 20, 2018 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DannyBen