Skip to content

Fix PHP 8.4 deprecation warnings #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

koraga
Copy link
Contributor

@koraga koraga commented Feb 24, 2025

PHP: 8.4
L5 Swagger: 9.0.0

I catch warnings:

Deprecated: swagger_ui_dist_path(): Implicitly marking parameter $asset as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/vendor/darkaonline/l5-swagger/src/helpers.php on line 15

deprecate-implicitly-nullable-types

This PR adds nullable type to parameters

@coveralls
Copy link

Coverage Status

coverage: 99.688%. remained the same
when pulling 2378288 on koraga:fix-deprecated-php-84
into 7fffe3d on DarkaOnLine:master.

@DarkaOnLine DarkaOnLine merged commit 72b4ca5 into DarkaOnLine:master Feb 24, 2025
6 checks passed
daehli pushed a commit to daehli/L5-Swagger that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants