Skip to content

Update docs mentioning Go version + trace Makefile. #2992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

remeh
Copy link
Contributor

@remeh remeh commented Feb 5, 2019

What does this PR do?

Updates docs mentioning the Go version needed to build the Agent.

Also updates the trace Agent Makefile.

@remeh remeh added [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead.. changelog/no-changelog labels Feb 5, 2019
@remeh remeh added this to the 6.10.0 milestone Feb 5, 2019
@remeh remeh requested review from a team as code owners February 5, 2019 13:19
Copy link
Contributor

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Feb 5, 2019

Codecov Report

Merging #2992 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2992      +/-   ##
==========================================
+ Coverage   53.25%   53.26%   +0.01%     
==========================================
  Files         528      528              
  Lines       37632    37632              
==========================================
+ Hits        20041    20045       +4     
+ Misses      16402    16397       -5     
- Partials     1189     1190       +1
Impacted Files Coverage Δ
pkg/trace/writer/trace.go 89.7% <0%> (-1.97%) ⬇️
pkg/logs/auditor/auditor.go 71.83% <0%> (+0.7%) ⬆️
pkg/forwarder/domain_forwarder.go 92.91% <0%> (+1.57%) ⬆️
pkg/forwarder/transaction.go 82.9% <0%> (+4.27%) ⬆️

@remeh remeh merged commit 0e22d12 into master Feb 5, 2019
@remeh remeh deleted the remeh/docs-go1-11-5 branch February 5, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants