Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract trace context from SNS->SQS event when SNS has raw message delivery #621

Merged

Conversation

nhulston
Copy link
Contributor

@nhulston nhulston commented Feb 18, 2025

What does this PR do?

Adds support for extracting Datadog trace context from SQS message attributes when receiving messages from SNS with raw message delivery enabled.

Motivation

#579

Testing Guidelines

Tested manually with Lambda -> SNS -> SQS -> Lambda when SNS had raw message delivery enabled:
Screenshot 2025-02-18 at 1 34 40 PM
as you can see, both Lambdas and the SQS inferred span are on the same trace, but there is a missing SNS span (as expected).

Also added unit tests

Additional Notes

While we can extract the trace context and create the SQS inferred span, we can't create the SNS inferred span in this scenario since information is lost due to raw message delivery.

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@nhulston nhulston marked this pull request as ready for review February 18, 2025 18:38
@nhulston nhulston requested a review from a team as a code owner February 18, 2025 18:38
@nhulston nhulston merged commit 9a14428 into main Feb 18, 2025
30 checks passed
@nhulston nhulston deleted the nicholas.hulston/trace-context-from-sns-sqs-raw-message-delivery branch February 18, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants