-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
annotate test files for secrets #676
Merged
Merged
+150
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog Summary✅ Code Quality ✅ Code Security ✅ Dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR aims to improve secret detection in test files by refining file classification logic.
- Introduces a new function get_language_for_file that determines the language based on file extension, exact filename, or prefix.
- Adds integration tests to verify this classification logic.
- Updates a comment for a minor spelling correction.
Files not reviewed (1)
- misc/integration-test-secrets.sh: Language not supported
Comments suppressed due to low confidence (2)
crates/cli/src/file_utils.rs:85
- [nitpick] Consider renaming 'extensions_string' to 'extension_strings' to more clearly indicate that it represents a collection of extension strings.
let extensions_string = extensions
crates/cli/src/file_utils.rs:109
- [nitpick] Consider renaming 'prefix_string' to 'prefix_strings' to reflect that it contains multiple items.
let prefix_string = prefixes
amaanq
requested changes
Apr 3, 2025
amaanq
reviewed
Apr 3, 2025
amaanq
approved these changes
Apr 3, 2025
jasonforal
reviewed
Apr 7, 2025
jasonforal
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
We want to detect when a secret is detected in a test file.
What is your solution?
Run the same file classification for secrets than static analysis. When a result is found, we attempt to detect if this is a test file or not. If yes, we add the test classification that is later added to the SARIF file.
Testing
Added integration/end to end tests in
misc/integration-test-secrets.sh