[SDS-1024] Bump dd-sds in datadog-static-analyzer #690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artslidd
commented
Apr 16, 2025
| @@ -51,7 +51,7 @@ pub struct SarifReportMetadata { | |||
|
|
|||
| #[derive(Debug, Clone)] | |||
| pub enum SarifRule { | |||
| StaticAnalysis(Rule), | |||
| StaticAnalysis(Box<Rule>), | |||
There was a problem hiding this comment.
I did this because of
jasonforal
approved these changes
Apr 16, 2025
fuchsnj
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
The next time the SCA team tries to bump the dd-sds lib, they will have a hard time understanding breaking changes.
What is your solution?
I prefer bumping the lib myself, as I know how to solve the breaking changes.
Alternatives considered
What the reviewer should know