-
Notifications
You must be signed in to change notification settings - Fork 462
[chore] upgrade x/crypto to 0.35.0 #3477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -67,7 +67,7 @@ require ( | |||
go.uber.org/zap v1.27.0 // indirect | |||
golang.org/x/exp v0.0.0-20250210185358-939b2ce775ac // indirect | |||
golang.org/x/mod v0.24.0 // indirect | |||
golang.org/x/net v0.37.0 // indirect | |||
golang.org/x/net v0.36.0 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 Library Vulnerability
golang.org/x/net → 0.36.0
View all suggested fixes
golang.org/x/net v0.36.0 // indirect | |
golang.org/x/net vv0.39.1-0.20250416010141-ea0c1d94f5e0// indirect |
golang.org/x/net v0.36.0 // indirect | |
golang.org/x/net vv0.38.0// indirect |
golang.org/x/net vulnerable to Cross-site Scripting (...read more)
@@ -67,7 +67,7 @@ require ( | |||
go.uber.org/zap v1.27.0 // indirect | |||
golang.org/x/exp v0.0.0-20250210185358-939b2ce775ac // indirect | |||
golang.org/x/mod v0.24.0 // indirect | |||
golang.org/x/net v0.37.0 // indirect | |||
golang.org/x/net v0.36.0 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 Library Vulnerability
golang.org/x/net → 0.36.0
View all suggested fixes
golang.org/x/net v0.36.0 // indirect | |
golang.org/x/net vv0.39.1-0.20250416010141-ea0c1d94f5e0// indirect |
golang.org/x/net v0.36.0 // indirect | |
golang.org/x/net vv0.38.0// indirect |
golang.org/x/net vulnerable to Cross-site Scripting (...read more)
Realized this is already covered in #3468 . Closing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's an unintended downgrade.
@@ -4,7 +4,7 @@ go 1.23.0 | |||
|
|||
require ( | |||
github.com/DataDog/dd-trace-go/v2 v2.1.0-dev.1 | |||
github.com/redis/rueidis v1.0.56 | |||
github.com/redis/rueidis v1.0.55 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intended?
@@ -5,7 +5,7 @@ go 1.23.0 | |||
require ( | |||
github.com/DataDog/dd-trace-go/v2 v2.1.0-dev.1 | |||
github.com/stretchr/testify v1.10.0 | |||
github.com/valkey-io/valkey-go v1.0.56 | |||
github.com/valkey-io/valkey-go v1.0.55 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto.
@@ -67,7 +67,7 @@ require ( | |||
go.uber.org/zap v1.27.0 // indirect | |||
golang.org/x/exp v0.0.0-20250210185358-939b2ce775ac // indirect | |||
golang.org/x/mod v0.24.0 // indirect | |||
golang.org/x/net v0.37.0 // indirect | |||
golang.org/x/net v0.36.0 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤨
What does this PR do?
Upgrades x/crypto to
v0.35.0
Motivation
https://github.com/DataDog/dd-trace-go/security/dependabot/143
Reviewer's Checklist
golangci-lint run
locally.Unsure? Have a question? Request a review!