Skip to content

[chore] upgrade x/crypto to 0.35.0 #3477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

hannahkm
Copy link
Contributor

What does this PR do?

Upgrades x/crypto to v0.35.0

Motivation

https://github.com/DataDog/dd-trace-go/security/dependabot/143

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Apr 30, 2025
@@ -67,7 +67,7 @@ require (
go.uber.org/zap v1.27.0 // indirect
golang.org/x/exp v0.0.0-20250210185358-939b2ce775ac // indirect
golang.org/x/mod v0.24.0 // indirect
golang.org/x/net v0.37.0 // indirect
golang.org/x/net v0.36.0 // indirect

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Library Vulnerability

golang.org/x/net → 0.36.0

View all suggested fixes
Suggested change
golang.org/x/net v0.36.0 // indirect
golang.org/x/net vv0.39.1-0.20250416010141-ea0c1d94f5e0// indirect
Suggested change
golang.org/x/net v0.36.0 // indirect
golang.org/x/net vv0.38.0// indirect
golang.org/x/net vulnerable to Cross-site Scripting (...read more)

View in Datadog  Leave us feedback  Documentation

@@ -67,7 +67,7 @@ require (
go.uber.org/zap v1.27.0 // indirect
golang.org/x/exp v0.0.0-20250210185358-939b2ce775ac // indirect
golang.org/x/mod v0.24.0 // indirect
golang.org/x/net v0.37.0 // indirect
golang.org/x/net v0.36.0 // indirect

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Library Vulnerability

golang.org/x/net → 0.36.0

View all suggested fixes
Suggested change
golang.org/x/net v0.36.0 // indirect
golang.org/x/net vv0.39.1-0.20250416010141-ea0c1d94f5e0// indirect
Suggested change
golang.org/x/net v0.36.0 // indirect
golang.org/x/net vv0.38.0// indirect
golang.org/x/net vulnerable to Cross-site Scripting (...read more)

View in Datadog  Leave us feedback  Documentation

@hannahkm
Copy link
Contributor Author

Realized this is already covered in #3468 . Closing

@hannahkm hannahkm closed this Apr 30, 2025
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's an unintended downgrade.

@@ -4,7 +4,7 @@ go 1.23.0

require (
github.com/DataDog/dd-trace-go/v2 v2.1.0-dev.1
github.com/redis/rueidis v1.0.56
github.com/redis/rueidis v1.0.55
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended?

@@ -5,7 +5,7 @@ go 1.23.0
require (
github.com/DataDog/dd-trace-go/v2 v2.1.0-dev.1
github.com/stretchr/testify v1.10.0
github.com/valkey-io/valkey-go v1.0.56
github.com/valkey-io/valkey-go v1.0.55
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

@@ -67,7 +67,7 @@ require (
go.uber.org/zap v1.27.0 // indirect
golang.org/x/exp v0.0.0-20250210185358-939b2ce775ac // indirect
golang.org/x/mod v0.24.0 // indirect
golang.org/x/net v0.37.0 // indirect
golang.org/x/net v0.36.0 // indirect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants