Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tracer): remove unused method and constant #12818

Merged
merged 2 commits into from
Mar 25, 2025
Merged

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Mar 20, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@mabdinur mabdinur requested a review from a team as a code owner March 20, 2025 18:15
@mabdinur mabdinur requested a review from ZStriker19 March 20, 2025 18:15
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/_trace/tracer.py                                                @DataDog/apm-sdk-api-python

Copy link
Contributor

github-actions bot commented Mar 20, 2025

Bootstrap import analysis

Comparison of import times between this PR and main.

Summary

The average import time in this PR is: 234 ± 1 ms.

The average import time in main is: 237 ± 2 ms.

The import time difference between this PR and main is: -2.05 ± 0.08 ms.

Import time breakdown

The following import paths have grown:

ddtrace.auto 2.196 ms (0.94%)
ddtrace.bootstrap.sitecustomize 2.196 ms (0.94%)
ddtrace.bootstrap.preload 2.072 ms (0.88%)
ddtrace.internal.products 1.913 ms (0.82%)
ddtrace.internal.symbol_db.remoteconfig 0.828 ms (0.35%)
multiprocessing.sharedctypes 0.662 ms (0.28%)
multiprocessing.heap 0.662 ms (0.28%)
mmap 0.662 ms (0.28%)
ddtrace.internal.symbol_db.symbols 0.083 ms (0.04%)
ddtrace.internal.safety 0.083 ms (0.04%)
multiprocessing 0.082 ms (0.04%)
multiprocessing.context 0.082 ms (0.04%)
ddtrace.internal.uwsgi 0.695 ms (0.30%)
importlib.metadata 0.210 ms (0.09%)
importlib.abc 0.073 ms (0.03%)
importlib.resources 0.073 ms (0.03%)
importlib.resources._common 0.073 ms (0.03%)
importlib.resources._adapters 0.073 ms (0.03%)
importlib.metadata._adapters 0.062 ms (0.03%)
ddtrace.settings.dynamic_instrumentation 0.095 ms (0.04%)
ddtrace.internal.remoteconfig.client 0.085 ms (0.04%)
ddtrace.internal.remoteconfig._pubsub 0.085 ms (0.04%)
ddtrace.internal.remoteconfig._publishers 0.085 ms (0.04%)
ddtrace.settings.crashtracker 0.093 ms (0.04%)
ddtrace.internal.flare.flare 0.066 ms (0.03%)
ddtrace._trace.trace_handlers 0.124 ms (0.05%)
ddtrace._trace.utils_botocore.span_tags 0.065 ms (0.03%)
ddtrace._trace.utils_botocore.aws_payload_tagging 0.065 ms (0.03%)
ddtrace.vendor.jsonpath_ng 0.065 ms (0.03%)
ddtrace.vendor.jsonpath_ng.jsonpath 0.065 ms (0.03%)
ddtrace.vendor.jsonpath_ng.lexer 0.065 ms (0.03%)
ddtrace._trace.utils 0.058 ms (0.02%)

The following import paths have shrunk:

ddtrace.auto 4.221 ms (1.80%)
ddtrace.bootstrap.sitecustomize 3.559 ms (1.52%)
ddtrace.bootstrap.preload 3.385 ms (1.44%)
ddtrace.internal.products 2.593 ms (1.11%)
ddtrace.internal.symbol_db.remoteconfig 0.953 ms (0.41%)
multiprocessing 0.684 ms (0.29%)
multiprocessing.context 0.684 ms (0.29%)
multiprocessing.reduction 0.606 ms (0.26%)
pickle 0.606 ms (0.26%)
_compat_pickle 0.606 ms (0.26%)
multiprocessing.process 0.078 ms (0.03%)
ddtrace.internal.remoteconfig._connectors 0.099 ms (0.04%)
ddtrace.internal.symbol_db.symbols 0.087 ms (0.04%)
ddtrace.settings.symbol_db 0.087 ms (0.04%)
multiprocessing.sharedctypes 0.083 ms (0.04%)
multiprocessing.heap 0.083 ms (0.04%)
multiprocessing.util 0.083 ms (0.04%)
ddtrace.internal.remoteconfig.client 0.633 ms (0.27%)
importlib.metadata 0.218 ms (0.09%)
importlib.abc 0.078 ms (0.03%)
importlib.resources 0.078 ms (0.03%)
importlib.resources._common 0.078 ms (0.03%)
csv 0.077 ms (0.03%)
importlib.metadata._collections 0.063 ms (0.03%)
ddtrace.debugging._config 0.070 ms (0.03%)
ddtrace.settings.exception_replay 0.070 ms (0.03%)
ddtrace.settings.profiling 0.627 ms (0.27%)
ddtrace.vendor.psutil 0.627 ms (0.27%)
ddtrace.vendor.psutil._pslinux 0.627 ms (0.27%)
ddtrace.vendor.psutil._psutil_linux 0.080 ms (0.03%)
ddtrace.settings.crashtracker 0.091 ms (0.04%)
ddtrace.internal.datadog.profiling.crashtracker 0.091 ms (0.04%)
ddtrace.internal.datadog.profiling.crashtracker._crashtracker 0.091 ms (0.04%)
ddtrace.internal.flare._subscribers 0.075 ms (0.03%)
ddtrace._trace.trace_handlers 0.174 ms (0.07%)
ddtrace._trace.utils_botocore.span_pointers 0.090 ms (0.04%)
ddtrace._trace.utils_botocore.span_pointers.dynamodb 0.090 ms (0.04%)
ddtrace._trace.utils_botocore.span_tags 0.085 ms (0.04%)
ddtrace._trace.utils_botocore.aws_payload_tagging 0.085 ms (0.04%)
ddtrace.vendor.jsonpath_ng 0.085 ms (0.04%)
ddtrace.vendor.jsonpath_ng.jsonpath 0.085 ms (0.04%)
ddtrace.vendor.jsonpath_ng.lexer 0.085 ms (0.04%)
ddtrace.vendor.ply.lex 0.085 ms (0.04%)
ddtrace 0.662 ms (0.28%)

@pr-commenter
Copy link

pr-commenter bot commented Mar 20, 2025

Benchmarks

Benchmark execution time: 2025-03-21 18:33:35

Comparing candidate commit afc608d in PR branch munir/remove-deadcode with baseline commit 5c8fb46 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 498 metrics, 2 unstable metrics.

@mabdinur mabdinur enabled auto-merge (squash) March 21, 2025 17:42
@mabdinur mabdinur added the changelog/no-changelog A changelog entry is not required for this PR. label Mar 24, 2025
@mabdinur mabdinur merged commit be173d8 into main Mar 25, 2025
794 of 796 checks passed
@mabdinur mabdinur deleted the munir/remove-deadcode branch March 25, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants