Skip to content

refactor: remove cycle in processor stats #13204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

P403n1x87
Copy link
Contributor

@P403n1x87 P403n1x87 commented Apr 15, 2025

We remove a static circular import on typing in the processor stats module.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

We remove a static circular import on typing in the processor stats
module.
@P403n1x87 P403n1x87 added the changelog/no-changelog A changelog entry is not required for this PR. label Apr 15, 2025
@P403n1x87 P403n1x87 requested a review from a team as a code owner April 15, 2025 09:53
@P403n1x87 P403n1x87 requested a review from erikayasuda April 15, 2025 09:53
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/internal/processor/stats.py                                     @DataDog/apm-core-python

Copy link
Contributor

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 234 ± 4 ms.

The average import time from base is: 233 ± 3 ms.

The import time difference between this PR and base is: 0.7 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.825 ms (0.78%)
ddtrace.bootstrap.sitecustomize 1.165 ms (0.50%)
ddtrace.bootstrap.preload 1.165 ms (0.50%)
ddtrace.internal.products 1.165 ms (0.50%)
ddtrace.internal.remoteconfig.client 0.595 ms (0.25%)
ddtrace 0.660 ms (0.28%)

@pr-commenter
Copy link

pr-commenter bot commented Apr 15, 2025

Benchmarks

Benchmark execution time: 2025-04-15 10:57:32

Comparing candidate commit ec6afc1 in PR branch refactor/processor-stats-cycle with baseline commit 717c54c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 506 metrics, 2 unstable metrics.

@P403n1x87 P403n1x87 enabled auto-merge (squash) April 15, 2025 14:27
@P403n1x87 P403n1x87 merged commit 70e052b into main Apr 15, 2025
729 of 731 checks passed
@P403n1x87 P403n1x87 deleted the refactor/processor-stats-cycle branch April 15, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants